build: add OpenSSL gyp artifacts to .gitignore #40967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
targos
approved these changes
Nov 25, 2021
lpinca
commented
Nov 25, 2021
Comment on lines
90
to
+95
| /deps/openssl/openssl.props | ||
| /deps/openssl/openssl.targets | ||
| /deps/openssl/openssl.xml | ||
| /deps/openssl/openssl-fipsmodule.props | ||
| /deps/openssl/openssl-fipsmodule.targets | ||
| /deps/openssl/openssl-fipsmodule.xml |
There was a problem hiding this comment.
We could use
/deps/openssl/openssl*.props
/deps/openssl/openssl*.targets
/deps/openssl/openssl*.xml
if preferred.
Trott
approved these changes
Nov 26, 2021
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Nov 26, 2021
VoltrexKeyva
approved these changes
Nov 27, 2021
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eadfbae |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Fixes: #40855 PR-URL: #40967 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Fixes: #40855 PR-URL: #40967 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Fixes: #40855 PR-URL: #40967 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Fixes: #40855 PR-URL: #40967 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40855